feat: modules support - #296
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
85fbad9 to
f0e17e2
Compare
710cacf to
ba47cb2
Compare
70549ee to
47d3a66
Compare
| "time" | ||
|
|
||
| "github.com/creasty/defaults" | ||
| "github.com/knadh/koanf/v2" |
There was a problem hiding this comment.
We usually use viper for this, so do we really need koanf?
Especially as one of its deps github.com/mitchellh/copystructure is archived.
There was a problem hiding this comment.
We can't use viper for this use-case. Viper can't parse and store ambiguous values, as well as some issues with Viper:
- viper breaks JSON, YAML, TOML, HCL language specs by Add viper.SetKeysCaseSensitive() to disable automatic key lowercasing. spf13/viper#635.
- hardcoded parsers
So we can't really use Viper here.
47d3a66 to
8f02e4c
Compare
0758404 to
299e11b
Compare
299e11b to
dd47031
Compare
dd47031 to
41d81f6
Compare
41d81f6 to
c41eb72
Compare
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
c41eb72 to
f2e796a
Compare
cb80
left a comment
There was a problem hiding this comment.
Please bump the chart version.
Signed-off-by: Danylo Shevchenko <danilshevchenko123456@gmail.com>
f2e796a to
dcb2875
Compare
What this PR does / why we need it:
Special notes for your reviewer:
Release note:
feat: module extensions